Add Equal operator support#20
Open
drewster99 wants to merge 2 commits into
Open
Conversation
This commit adds support for the 'Equal' ONNX operator in MPSX, which resolves issue prisma-ai#19 where users encountered 'unsupportedOperator: "Equal"' error when trying to run inference on models that use the Equal operator (such as Silero VAD). Implementation: - Added Equal.swift file implementing the Equal operator using MPSGraph.equalTo() - Registered the Equal operator in the main ONNX switch statement in Onnx.swift - Following the same pattern as other comparison operators like Less and Greater
Corrected the implementation to use the proper MPSGraph API 'equal' method instead of 'equalTo' which was not available in the Metal Performance Shaders Graph API. The correct method is 'equal(a, b, name: nil)' as shown in the DSL.swift file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the 'Equal' ONNX operator in MPSX, which resolves issue #19 where users encountered 'unsupportedOperator: "Equal"' error when trying to run inference on models that use the Equal operator (such as Silero VAD).\n\nImplementation:\n- Added Equal.swift file implementing the Equal operator using MPSGraph.equalTo()\n- Registered the Equal operator in the main ONNX switch statement in Onnx.swift\n- Following the same pattern as other comparison operators like Less and Greater\n\nFixes #19