Repository navigation
Conversation
…r#198) The transaction page still rendered <Row>, which no longer exists since the detail helpers were merged into DetailRow (prism-explorer#69), so the page failed the type check. DetailRow takes the same label, value, mono and link props, and the contract row keeps its /contract/<id> link.
|
@bfs2021 is attempting to deploy a commit to the thewealthyplace100-8633's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The transaction page renders
<Row>in the Soroban invocation card, butRowis no longer defined or imported since the detail helpers were merged intoDetailRow(#69), so the page fails the type check and the build (Fixes #198).Root cause
The three rows in that card were left behind by the merge: the file imports
DetailRowand uses it elsewhere, but Contract, Function and Return Value still referenced the removedRowhelper.Fix
Render those three rows with
DetailRow, which takes the samelabel/value/mono/linkprops. The contract row keeps its/contract/<id>link.Testing
npx tsc --noEmitreports no errors forfrontend/src/app/(app)/tx/[hash]/page.tsx. The remaining type errors in the repo belong to other open issues (for example the missingDetailRowimport on the account page), not to this file.DetailRowis the component every other detail card already renders.