Fill freed capacity in the same tracking cycle - #118
Merged
Conversation
Files that finished processing released their capacity only after `_stage_new_files` had already run, so a waiting file sat idle for a full cycle before taking the freed slot. - Move `_stage_new_files` after the failure and completion handlers, and keep `_check_inactivity` last so a cycle that just staged work is not counted as idle - Move the idle-clock announcement into `_check_inactivity`, where the settled state is now final, and guard it so it logs once per settling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A finished file's slot sat empty until the next cycle, and the idle-clock message only appeared if a file happened to complete on that exact cycle. Both come from the ordering of steps in
_run_tracking_cycle._check_inactivitywhenever work runs out, guarded by a flag so it fires once per quiet spell.