Periodically warn for long-pending workers - #113
Merged
Conversation
yoonspark
requested changes
Aug 12, 2026
yoonspark
left a comment
yoonspark
left a comment
Collaborator
There was a problem hiding this comment.
Overall looking good, but needs some updates. Please see the comments below.
Comment on lines
+153
to
+157
| # Track how long each currently-pending worker job has been pending, | ||
| # and the last 10-minute threshold logged for it, so warnings repeat | ||
| # every 10 minutes instead of flooding every poll cycle | ||
| self._worker_pending_since: dict[str, dict[int, float]] = defaultdict(dict) | ||
| self._worker_pending_alerted: dict[str, dict[int, int]] = defaultdict(dict) |
Collaborator
There was a problem hiding this comment.
We should eventually track these two states together they always pair up for a given pending worker. But the refactor can be rolled into a greater one that involves centralization of all task state tracking (e.g., use TaskState dataclass). Ok as is now.
yoonspark
approved these changes
Aug 13, 2026
yoonspark
left a comment
yoonspark
left a comment
Collaborator
There was a problem hiding this comment.
Left two optional suggestions — take as you see fit. Both non-blocking, the PR is approved.
Nina-mvH
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the pipeline log to:
Log the number of files staged, completed, and failed upon pipeline terminationIn Enhance pipeline logging #17, this was intended to be a warning, but I just made itinfolevel since nothing is technically wrong. This can be easily updated.Ref #17