feat: add embed task for text embeddings - #178
Merged
Merged
Conversation
cswaney
requested changes
Jul 27, 2026
cswaney
left a comment
Member
There was a problem hiding this comment.
Approved for merge after the following updates:
- Remove
per-line - Replace
promptandprompt-namewithkwargs - Add
use_encode_document = Falseparams to top intoencode_document. Also, explains whatencode_documentdoes more precisely.
Nina-mvH
force-pushed
the
3-add-embeddings-task
branch
from
July 28, 2026 16:22
4b92a1d to
0a6c8b2
Compare
cswaney
self-requested a review
July 28, 2026 16:39
cswaney
approved these changes
Jul 28, 2026
Contributor
Author
What
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an initial implementation of an
embedtask (currently only supports text inputs and.npyoutputs)Tested with
sentence-transformers/all-MiniLM-L6-v2Deferred
Open design question
This task does not fall neatly into the
textgrouping -- it will support all input types and outputs embeddings; it seems like the task should not live in a sub-folder?