fix(lib): include any-to-any models in image-text-to-text filter - #497
Merged
Merged
Conversation
vLLM's VLM code path also serves any-to-any (omni/multimodal) models, so filtering /api/models by image=image-text-to-text should surface both tags — otherwise the OCR batch launcher (and any other caller of that filter) hides valid models. Mirrors the existing text-generation entry. Closes #496
ReviewSmall, well-scoped fix — the change and its test coverage line up cleanly with the stated problem. Code quality
Bugs/correctness
Test coverage
Coverage badge
Security/performance
Overall: looks good to merge pending a sanity check on the coverage badge number. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
image-text-to-textentry toCOMPATIBLE_PIPELINESthat widens toany-to-any, mirroring the existingtext-generationentry (which already lists both).GET /api/models?image=image-text-to-text) now surfaces omni/multimodal models alongside VLMs.Test plan
just lint— cleanjust test— 960 passed, 7 skippedany-to-anymodels come back when filtering byimage-text-to-textcurl /api/models?image=image-text-to-textreturned 3any-to-anymodels alongside 57image-text-to-text(before the fix, only the latter surfaced)Closes #496