Repository navigation
Conversation
Drop résumé stats and filler from the about page and four essays, and correct the meeting-cost rate to about $96/hour. Branch from 912023c so Past the Pilot and Hyperscience stay off. Co-authored-by: prime3679 <prime3679@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43c8aece1e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <hr class="border-foreground/10 my-8" /> | ||
|
|
||
| <h2 class="text-base font-medium mt-8 mb-3">what separates the best from the rest</h2> | ||
| <h2 class="text-base font-medium mt-8 mb-3">what the best PMs do</h2> |
There was a problem hiding this comment.
Keep the new section heading lowercase
The new public-facing heading introduces uppercase PMs, contrary to the lowercase UI-copy requirement in AGENTS.md. This abbreviation is not a proper noun, so the documented exception does not apply. Use pms or spell out product managers to preserve the required editorial convention.
AGENTS.md reference: AGENTS.md:L29-L30
Useful? React with 👍 / 👎.
about.astro is in the architecture source set, so the copy change stale the digest. Update the contract digest and the matching marker in the human architecture map. Co-authored-by: prime3679 <prime3679@users.noreply.github.com>
This branch is the intended live state
Production matches commit
912023c(PR #96, Past the Pilot offer taken off the site). This branch starts there and applies the October 23 copy fixes. It does not start frommain.mainis ahead by the merge of PR #97, which puts the Past the Pilot offer back and adds Hyperscience (plus Disney/ESPN and EA Sports in the career list). That must stay off the site.A merge of this branch into
mainconflicts.git merge-treereports content conflicts in:src/pages/about.astrotests/work.spec.tsPR #97 rewrote the about page onto
src/data/career.ts. These copy fixes edit the résumé text that still lives inabout.astroat912023c. Resolving the conflict by keepingmainwould drop the about-page edits and keep the offer, Hyperscience, and the new career list. The essay edits are only on this branch and would apply, but the offer pages added onmain(src/pages/past-the-pilot.astroandsrc/pages/past-the-pilot/thanks.astro) would remain unless they are removed on purpose.Do not merge this with the GitHub merge button. The tree at the tip of
copy-fixes-1023is the site that should be live. Deploy that tree. Do not deploymain.What changed
Every find/replace from the October 23 spec:
about.astrois in that source setThe homepage was not in the spec. "past: SiriusXM, Disney+, EA." is unchanged. The lab flagship ledger section titled "past the pilot" is the one already live at
912023c. It is not the sales offer.Verification
npm run check: 0 errorsnpm run build: succeeded, 18 pages, no/past-the-pilot/routenpx vitest run: 64 passednode .hermes/verifiers/public-surface-scan.mjs: passedpublic/lab/meeting-cost/index.html, which the surface scan skips.Cloudflare credentials are not available here (
wrangler whoamiis not authenticated, and no API token is set), so this was not deployed.