fix(security): restrict generic git repository URLs to network transports - #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository identifiers for the generic Git provider were validated only as
string|max:500before being passed togit. Git accepts addresses that are not network URLs, so a repository could be pointed at things it should never reach.Adds a provider-aware
ValidRepositoryIdentifierrule: API-backed providers take anowner/reposlug, and the generic Git provider is limited tohttps,http,sshandgitURLs or scp-styleuser@host:path.The same check runs again where
gitis actually invoked, so identifiers already stored — or written by any path other than the form — are refused too. Command arguments now use a--separator so an address can never be read as an option.Split out of #172 so it can be reviewed and released on its own.