Replace SDATTool with nitrosfx v0.1 - #1250
Open
h2o-DS wants to merge 2 commits into
Open
Conversation
lhearachel
reviewed
Aug 2, 2026
| Func_FadeBattlerSprite BATTLE_ANIM_DEFENDER, 0, 1, BATTLE_COLOR_RED, 10, 0 | ||
| Func_Shake 1, 0, 1, 2, BATTLE_ANIM_BATTLER_SPRITE_DEFENDER | ||
| PlayLoopedSoundEffectR SEQ_SE_DP_W052, 3, 4 | ||
| PlayLoopedSoundEffectR SEQ_SE_DP_W052_sseq, 3, 4 |
Collaborator
There was a problem hiding this comment.
question: Could we strip the extension before generating the NAIX? That would greatly reduce the scope of changes. As-is, GitHub is choking on this PR quite a bit due to the number of files that have been touched.
Collaborator
Author
There was a problem hiding this comment.
I would prefer the extensions, but that can be reverted if required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
SDATToolwithnitrosfxv0.1Unpacks
swarfiles intowav.Replaces
generated/sdat.hwithres/sound/pl_sound_data.naixgenerated from the sdat file.Moves files related to pokemon cries into their respective species folders. Adding species will cause the added cries to be added to the sdat's private folder, but will require editing
res/sound/pl_sound_data.jsonin order to be added to the SDAT; this will be addressed in a future PR.Files in
res/sound/WAVARCare IMA-ADPCM encoded due to some of them not currently being able to round-tripped in PCM16.