comm_command - #1179
Conversation
55 functions that gave me a lot of clarity
scbroede
left a comment
There was a problem hiding this comment.
imo just like with script commands, these should all be named in the imperative sense (ie. verb-first, phrased as a command). aside from the ones i've individually flagged, commands not already following this convention should have Recv in front.
also this has conflicts
I think that adding |
Builds on #1161
This PR is long but ultimately has 3 goals:
Fully document the contents of
comm_command.c. This file should be reviewed thoroughly, and is thankfully short.Give general names and corresponding constants to each other
comm_command_file, named as such when they contain aCommCmdTablelist of functions. These are not intended to be documented further and only the tables themselves need to be looked at when reviewing, since they will contain all already documented functions that had their names changed.Use the
COMM_CMD_constants in appropriate locations in order to maintain functionality when adding new communication functions to the base table. I'm pretty sure I found all instances, but if I missed any I would like that to mentioned as a part of this review.