Decompile overlay_01_021F3D38 by PikalaxALT · Pull Request #495 · pret/pokeheartgold

PikalaxALT · 2026-07-29T11:36:04Z

Must come after #490
Must come before #493

PR checklist

This comment contains a description of changes (with reason).
The ROM compiles to matching locally (make compare_heartgold && make compare_soulsilver).
All C code is correctly formatted (git clang-format).
This pull request is labeled according to the kind of work it represents.
New or updated code labels follow the style guide
This work adheres to the AI policy.
The author has joined the pret discord server and sent a message in #pokeheartgold to verify that they are human

Pixelstyx · 2026-07-29T14:10:11Z

 void sub_02039B7C(void);
 BOOL sub_020392A0(void);
-UnkStruct_ov44_0223197C* sub_020396FC(SaveData*, int);
+UnkStruct_ov44_0223197C *sub_020396FC(SaveData *, int);


Suggested change

UnkStruct_ov44_0223197C *sub_020396FC(SaveData *, int);

UnkStruct_ov44_0223197C *sub_020396FC(SaveData *saveData, int arg1);

Pixelstyx · 2026-07-29T14:18:14Z

        struct {
            const s16 *screenOffsets;
-            void *unk8;
+            const TouchscreenHitbox *unk8;


Suggested change

const TouchscreenHitbox *unk8;

const TouchscreenHitbox *touchscreenHitbox;

Will need to be changed in the corresponding c file as well.

Pixelstyx · 2026-07-29T14:21:35Z

 void ov42_022279FC(UnkStruct_ov42_02227060 *arg0, s32 arg1, enum HeapID heapID);
 void ov42_02227B04(UnkStruct_ov42_02227060 *arg0);
-s32 ov42_02227B5C(SpriteResource **arg0);
+BOOL ov42_02227B5C(SpriteResource **arg0);


Suggested change

BOOL ov42_02227B5C(SpriteResource **arg0);

BOOL ov42_02227B5C(SpriteResource **spriteResources);

or is it pSpriteResource?

Pixelstyx · 2026-07-29T14:27:32Z

 static BOOL Task_BugContestEncounter(TaskManager *taskManager);
 static BOOL Task_TutorialBattle(TaskManager *taskManager);
-static u32 sub_02051474(void *param0, u32 battleType);
+static u32 sub_02051474(LinkBattleRuleset *param0, u32 battleType);


Suggested change

static u32 sub_02051474(LinkBattleRuleset *param0, u32 battleType);

static u32 sub_02051474(LinkBattleRuleset *ruleset, u32 battleType);

Pixelstyx · 2026-07-29T14:27:45Z

 }

-static u32 sub_02051474(void *param0, u32 battleType) {
+static u32 sub_02051474(LinkBattleRuleset *param0, u32 battleType) {


Suggested change

static u32 sub_02051474(LinkBattleRuleset *param0, u32 battleType) {

static u32 sub_02051474(LinkBattleRuleset *ruleset, u32 battleType) {

Pixelstyx · 2026-07-29T14:36:07Z

    ov42_02228F94(arg0->unk6EC);
 }

 void ov44_02232248(UnkStruct_ov44_02232DA0 *arg0, enum HeapID arg1, NARC *arg2, s32 arg3) {


Suggested change

void ov44_02232248(UnkStruct_ov44_02232DA0 *arg0, enum HeapID arg1, NARC *arg2, s32 arg3) {

void ov44_02232248(UnkStruct_ov44_02232DA0 *arg0, enum HeapID heapID, NARC *narc_unused, s32 offset) {

Needs to be changed in the corresponding header file as well.

Pixelstyx · 2026-07-29T14:37:02Z

+    };
+
+    sp0.fileId += arg3;
+    arg0->unk6F4 = ov42_022293B8(&arg0->unk14.unk4, arg0->unk10, &sp0, arg1);


Suggested change

arg0->unk6F4 = ov42_022293B8(&arg0->unk14.unk4, arg0->unk10, &sp0, arg1);

arg0->unk6F4 = ov42_022293B8(&arg0->unk14.unk4, arg0->unk10, &sp0, heapID);

Pixelstyx · 2026-07-29T14:37:18Z

+        .compressed = FALSE,
+    };
+
+    sp0.fileId += arg3;


Suggested change

sp0.fileId += arg3;

sp0.fileId += offset;

Pixelstyx · 2026-07-29T14:46:58Z

+u8 DialogBox_PrintMessage(Window *window, String *string, Options *options, BOOL speedupFlag);
+u32 DialogBox_PrintMessageEx(Window *window, String *message, FontID fontId, u32 textSpeed, u8 speedUpEnabled, u32 autoScrollParam);
+u8 DialogBox_IsPrintFinished(u8 printerId);
+void DialogBox_AddWindowToLayer3WithXOffset(BgConfig *bgConfig, Window *window, u8 a2, GFBgLayer a3);


Suggested change

void DialogBox_AddWindowToLayer3WithXOffset(BgConfig *bgConfig, Window *window, u8 a2, GFBgLayer a3);

void DialogBox_AddWindowToLayer3WithXOffset(BgConfig *bgConfig, Window *window, u8 type, GFBgLayer layer);

…21F3D38

Pixelstyx

Forgot to actually give this a thumbs-up, I did the review earlier and didn't click submit.

adrienntindall

One small thing that might be a bigger thing unless I misunderstood something

adrienntindall · 2026-07-31T03:23:45Z

+BOOL SetSignpostMap(ScriptContext *ctx);
+BOOL SetSignpostAction(ScriptContext *ctx);
+BOOL WaitSignpostAction(ScriptContext *ctx);
 BOOL ScrCmd_TrainerTips(ScriptContext *ctx);
-BOOL ScrCmd_060(ScriptContext *ctx);
+BOOL WaitSignpost(ScriptContext *ctx);


Add ScrCmd_ prefixes back

Wait these are also defined in script_cmd_table.h, why do we have them twice?

...huh. never acknowledged that include/scrcmd.h existed. fixed.

adrienntindall

Will merge on resolution of conflicts

PikalaxALT added 5 commits July 17, 2026 08:27

Decompile overlay_01_021F3D38.s

069f3ed

Decompile text_0205B4EC

4ffcfe5

Signpost-related scrcmd renaming

46c7273

Document text_0205B4EC -> DialogBox

c9be294

overlay_01_021F3D38 -> field_signpost_window

05823b5

PikalaxALT self-assigned this Jul 29, 2026

PikalaxALT added the DECOMP label Jul 29, 2026

PikalaxALT mentioned this pull request Jul 29, 2026

Decompile ov04 (field gymmick) #493

Draft

7 tasks

Pixelstyx reviewed Jul 29, 2026

View reviewed changes

PikalaxALT added 2 commits July 29, 2026 19:03

Merge remote-tracking branch 'origin/master' into decomp/overlay_01_0…

e6bea0c

…21F3D38

Address review comments

f762986

PikalaxALT requested a review from Pixelstyx July 31, 2026 00:04

PikalaxALT marked this pull request as ready for review July 31, 2026 00:04

Pixelstyx approved these changes Jul 31, 2026

View reviewed changes

adrienntindall requested changes Jul 31, 2026

View reviewed changes

Remove redundant scrcmd decls

2bb521b

PikalaxALT requested a review from adrienntindall August 1, 2026 00:13

Pixelstyx mentioned this pull request Aug 5, 2026

A smidge of script command cleanup #497

Open

adrienntindall approved these changes Aug 5, 2026

View reviewed changes

	UnkStruct_ov44_0223197C sub_020396FC(SaveData , int);
	UnkStruct_ov44_0223197C sub_020396FC(SaveData saveData, int arg1);

	const TouchscreenHitbox *unk8;
	const TouchscreenHitbox *touchscreenHitbox;

	BOOL ov42_02227B5C(SpriteResource **arg0);
	BOOL ov42_02227B5C(SpriteResource **spriteResources);

	static u32 sub_02051474(LinkBattleRuleset *param0, u32 battleType);
	static u32 sub_02051474(LinkBattleRuleset *ruleset, u32 battleType);

	void ov44_02232248(UnkStruct_ov44_02232DA0 arg0, enum HeapID arg1, NARC arg2, s32 arg3) {
	void ov44_02232248(UnkStruct_ov44_02232DA0 arg0, enum HeapID heapID, NARC narc_unused, s32 offset) {

	arg0->unk6F4 = ov42_022293B8(&arg0->unk14.unk4, arg0->unk10, &sp0, arg1);
	arg0->unk6F4 = ov42_022293B8(&arg0->unk14.unk4, arg0->unk10, &sp0, heapID);

	void DialogBox_AddWindowToLayer3WithXOffset(BgConfig bgConfig, Window window, u8 a2, GFBgLayer a3);
	void DialogBox_AddWindowToLayer3WithXOffset(BgConfig bgConfig, Window window, u8 type, GFBgLayer layer);

Uh oh!

Conversation

PikalaxALT commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pixelstyx left a comment

Choose a reason for hiding this comment

Uh oh!

adrienntindall left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adrienntindall left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PikalaxALT commented Jul 29, 2026 •

edited

Loading