Decompile unk_02037C94 - #488
Open
ferwardle wants to merge 7 commits into
Open
Conversation
Contributor
Author
|
Just realized I put the declaration for WM_GetLinkLevel in the wrong header file, but not sure where to move it (it's from nitro.s) |
PikalaxALT
requested changes
Jul 4, 2026
PikalaxALT
requested changes
Jul 15, 2026
PikalaxALT
left a comment
PikalaxALT
left a comment
Collaborator
There was a problem hiding this comment.
these, also resolve merge conflicts pls
PikalaxALT
requested changes
Aug 1, 2026
PikalaxALT
left a comment
PikalaxALT
left a comment
Collaborator
There was a problem hiding this comment.
more things i noticed, also merge conflicts again
|
|
||
| void sub_02038B9C(u32 arg0, u32 arg1, u8 *arg2) { | ||
| u32 i; | ||
| s32 var_r4 = 1; |
Collaborator
There was a problem hiding this comment.
Suggested change
| s32 var_r4 = 1; | |
| BOOL var_r4 = TRUE; |
and so on below
|
|
||
| void sub_02038C3C(u32 arg0, s32 arg1) { | ||
| switch (arg0) { | ||
| case 819: |
Collaborator
There was a problem hiding this comment.
either all cases are decimal, or all case are hex
Comment on lines
+1187
to
+1189
| UnkStruct_sub_02039C6C *temp_r0 = Heap_Alloc(HEAP_ID_15, 104); | ||
| _021D4150 = temp_r0; | ||
| MI_CpuFill8(temp_r0, 0, 104); |
Collaborator
There was a problem hiding this comment.
Suggested change
| UnkStruct_sub_02039C6C *temp_r0 = Heap_Alloc(HEAP_ID_15, 104); | |
| _021D4150 = temp_r0; | |
| MI_CpuFill8(temp_r0, 0, 104); | |
| _021D4150 = Heap_Alloc(HEAP_ID_15, sizeof(UnkStruct_sub_02039C6C)); | |
| MI_CpuFill8(_021D4150, 0, sizeof(UnkStruct_sub_02039C6C)); |
| Heap_CreateAtEnd(HEAP_ID_3, HEAP_ID_15, 256); | ||
| UnkStruct_sub_02039C6C *temp_r0 = Heap_Alloc(HEAP_ID_15, 104); | ||
| _021D4150 = temp_r0; | ||
| MI_CpuFill8(temp_r0, 0, 104); |
| Heap_CreateAtEnd(HEAP_ID_3, HEAP_ID_15, 256); | ||
| UnkStruct_sub_02039C6C *temp_r0 = Heap_Alloc(HEAP_ID_15, 104); | ||
| _021D4150 = temp_r0; | ||
| MI_CpuFill8(temp_r0, 0, 104); |
Comment on lines
+1768
to
+1771
| s32 temp_r4 = sub_020348A8(i); | ||
| s32 temp_r6 = sub_020348CC(i); | ||
| sub_02039FB8(arg0, temp_r4, temp_r6, PlayerProfile_GetLanguage(sub_02034818(i))); | ||
| } |
Collaborator
There was a problem hiding this comment.
could probably inline these calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.