Remove pbadslot and customPbAdSlot from GPT Pre-Auction docs - #6612
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 047818b49d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Clarify the behavior of customPreAuction and default logic in GPID definition.
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@ChrisHuie tagging you as you mentioned in earlier meeting this was ready to merge |
3 participants
Fixes #6435
Motivation
pbadslot/customPbAdSlotsupport has been removed from Prebid.js and the module now focuses on GPID population.Description
pbadslotand thecustomPbAdSlotexample and replaced them with GPID-focused wording and guidance.useDefaultPreAuction(defaulting totrue) and thecustomPreAuction(adUnit, adServerAdSlot, gptAdUnitPath)signature.customPreAuctionsample usinggptAdUnitPath./features/pbAdSlot.html#the-gpid).Testing
markdownlint-clivianpmand ranmarkdownlint --config .markdownlint.json dev-docs/modules/gpt-pre-auction.md, and linting passed for the edited file.bundle installto ensure Jekyll dependencies were available and then ranbundle exec jekyll build, and the site built successfully without errors for the modified content.Codex Task