fix: the constructmarkup function directly interpola... in... - #374
Open
anupamme wants to merge 1 commit into
Open
Conversation
The constructMarkup function directly interpolates the 'ad' parameter (creative HTML/JavaScript from bid response) into a template string without sanitization, allowing arbitrary script injection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
src/mobileAndAmpRender.js.Vulnerability
V-001src/mobileAndAmpRender.js:95Description: The constructMarkup function directly interpolates the 'ad' parameter (creative HTML/JavaScript from bid response) into a template string without sanitization, allowing arbitrary script injection. The 'ad' variable comes from bidObject.adm which can contain malicious JavaScript that executes in the parent page context.
Evidence
Exploitation scenario: Attacker controlling bid response injects malicious script tag in 'adm' field: {"adm": "<script>alert('XSS')</script>"}.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This is a Node.js library - vulnerabilities affect downstream consumers who use this package.
Changes
src/mobileAndAmpRender.jsBehavior Preservation
The change is scoped to 1 file on the vulnerable path; it only tightens handling of untrusted input and leaves valid inputs unaffected.
Automated security fix by OrbisAI Security