Skip to content

New Adapter: Pixfuture - #4715

Open
pixfuture-media wants to merge 75 commits into
prebid:masterfrom
pixfuture-media:master
Open

New Adapter: Pixfuture#4715
pixfuture-media wants to merge 75 commits into
prebid:masterfrom
pixfuture-media:master

Conversation

@pixfuture-media

Copy link
Copy Markdown

The Pixfuture adapter has been updated to be compatible with v4.

pixfuture-media and others added 30 commits March 10, 2026 19:34
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
@pixfuture-media

Copy link
Copy Markdown
Author
Screenshot 2026-07-15 111550

Validation check is ok.

@przemkaczmarek

przemkaczmarek commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

I guess something is wrong with format of code:
image

Please run go fmt to address formatting issues.

@pixfuture-media

Copy link
Copy Markdown
Author

I reformated code:
./scripts/format.sh -f true
Running: gofmt -s -w exchange/adapter_builders.go

and validation don't give me any error too.
Please review it

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, fd5143e

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:28:	MakeRequests		66.7%
github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:78:	MakeBids		92.3%
github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:137:	getMediaTypeForBid	100.0%
total:									(statements)		81.4%

Comment thread adapters/pixfuture/pixfuture.go Outdated
Comment thread adapters/pixfuture/pixfuture.go Outdated
Comment thread static/bidder-params/pixfuture.json Outdated
Comment thread adapters/pixfuture/pixfuturetest/supplemental/bad_status.json
pixfuture-media and others added 2 commits July 22, 2026 08:57
Preserve USD when cur is omitted, keep getMediaTypeForBid errors, relax pix_id minLength to 1, and add missing supplemental fixtures.
@pixfuture-media

Copy link
Copy Markdown
Author

Requested changes and bug fixing done.
Tests pass.
Please review it

@pixfuture-media

Copy link
Copy Markdown
Author
test1 test2

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0e16009

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:28:	MakeRequests		77.8%
github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:78:	MakeBids		92.6%
github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:137:	getMediaTypeForBid	100.0%
total:									(statements)		86.7%

przemkaczmarek
przemkaczmarek previously approved these changes Jul 30, 2026
Comment thread adapters/pixfuture/pixfuture.go Outdated
Comment thread exchange/adapter_builders.go
@pixfuture-media

Copy link
Copy Markdown
Author

The latest requested changes were made.
Please review it and merge to master branch

ccorbo
ccorbo previously approved these changes Jul 30, 2026
przemkaczmarek
przemkaczmarek previously approved these changes Jul 31, 2026
@pixfuture-media
pixfuture-media dismissed stale reviews from przemkaczmarek and ccorbo via 8567407 July 31, 2026 13:37
@pixfuture-media

Copy link
Copy Markdown
Author

All tests successfully passed on my site.
Screenshot 2026-07-31 094937

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8567407

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:28:	MakeRequests		81.2%
github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:62:	MakeBids		92.6%
github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:121:	getMediaTypeForBid	100.0%
total:									(statements)		89.8%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants