HyperBrainz Bid Adapter: new adapter by krishnarx · Pull Request #15405 · prebid/Prebid.js

krishnarx · 2026-07-28T21:08:47Z

Type of change

New bidder adapter

Description of change

Resubmission of #15137, which was merged and then reverted in #15401
due to a build failure also fixed a bug where the adapter incorrectly used
the win-notification URL (nurl) as the video ad source instead of the
actual VAST content (adm/vastXml). This was causing video ads to fail
with a "no MediaFile URL found" error even on valid bids.

The Adkernel alias conflict raised in #15137 has also been discussed
with @ckbo3hrk (see #11544 / #15137) — the hyperbrainz alias in
adkernelBidAdapter.js is unused on our side and confirmed safe to
remove.

Other information

Related docs PR: prebid/prebid.github.io#6632

Maintainer contact: it@hyperbrainz.com

Test parameters for validating bids:

var adUnits = [
  {
    code: 'test-banner',
    mediaTypes: { banner: { sizes: [[300, 250], [728, 90]] } },
    bids: [{ bidder: 'hyperbrainz', params: { placementId: 'hb_test_banner', bidFloor: 0.30 } }]
  },
  {
    code: 'test-video',
    mediaTypes: { video: { context: 'outstream', playerSize: [640, 360], mimes: ['video/mp4'] } },
    bids: [{ bidder: 'hyperbrainz', params: { placementId: 'hb_test_video' } }]
  },
  {
    code: 'test-native',
    mediaTypes: { native: { ortb: { assets: [
      { id: 1, title: { len: 80 }, required: 1 },
      { id: 2, img: { type: 3, w: 1200, h: 627 }, required: 1 },
      { id: 3, data: { type: 1 } }
    ] } } },
    bids: [{ bidder: 'hyperbrainz', params: { placementId: 'hb_test_native' } }]
  }
];

…onsent, remove navigator access, add onBidBillable handler

…ailure

…perbrainz/Prebid.js into hyperbrainz-bid-adapter-agent

github-actions · 2026-07-28T21:10:26Z

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

modules/hyperbrainzBidAdapter.js

github-actions · 2026-07-28T21:10:56Z

This PR includes an adapter whose code does not match its file name. Bid adapter modules should be named <bidderCode>BidAdapter, userId <userIdCode>IdSystem, RTD <rtdCode>RtdProvider, and analytics <analyticsCode>AnalyticsAdapter.

github-actions · 2026-07-28T21:11:05Z

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

Changes to modules/hyperbrainzBidAdapter.js may need:
- es.array.push
- es.iterator.constructor
- es.iterator.find
- es.iterator.for-each
- es.iterator.map
- es.json.stringify
- esnext.iterator.constructor
- esnext.iterator.find
- esnext.iterator.for-each
- esnext.iterator.map
- esnext.json.parse
Changes to test/spec/modules/hyperbrainzBidAdapter_spec.js may need:
- es.array.with
- es.json.stringify
- esnext.array.with
- esnext.json.parse

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3096095243

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-28T21:13:20Z

+function buildSource(bidderRequest) {
+  return {
+    fd: 1,
+    tid: bidderRequest?.ortb2?.source?.tid || generateUUID(),


Respect enableTIDs before adding source.tid

When publishers leave enableTIDs at its default false, Prebid redacts ortb2.source.tid before adapter code runs; this fallback immediately generates a new source.tid anyway, so every HyperBrainz request still transmits a bidder-created auction transaction ID despite the privacy control. The repo-enforced module rules prohibit bidder-created TIDs, so omit source.tid unless Prebid supplied one.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-28T21:13:20Z

+}
+
+export const spec = {
+  code: BIDDER_CODE,


Remove stale HyperBrainz alias before registering code

When a build includes both adkernelBidAdapter and this new adapter, modules/adkernelBidAdapter.js still registers { code: 'hyperbrainz' } as an alias of adkernel; registering this spec under the same bidder code leaves aliasRegistry.hyperbrainz resolving to Adkernel and can also let import order decide which adapter owns bidderRegistry.hyperbrainz, so HyperBrainz bids can be routed or attributed incorrectly. Remove the old alias before adding this bidder code.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-28T21:13:20Z

+  const map = {};
+
+  validBids.forEach((bid) => {
+    const ep = bid.params.endpoint || defaultEndpoint;


Constrain custom endpoints to HyperBrainz domains

Because this accepts bid.params.endpoint verbatim, any page config can make the adapter POST the full auction payload, consent strings, EIDs, and first-party data to an arbitrary URL; the repo asks reviews to enforce the module rule that endpoint domains cannot be fully variable. Please restrict overrides to approved HyperBrainz hosts or remove the per-bid endpoint override.

Useful? React with 👍 / 👎.

barecheck · 2026-07-28T21:37:20Z

Barecheck - Code coverage report

Total: 96.66%

Your code coverage diff: 0.00% ▴

Uncovered files and lines

File	Lines
modules/hyperbrainzBidAdapter.js	163, 166, 193-194, 249-250, 278, 289-290, 349, 391, 394, 399-400, 406, 440, 462-463, 479-480, 632-633, 637

patmmccann · 2026-07-28T22:32:38Z

You need to also commit a d.ts file or convert your Js to ts. Also modify adkernal to remove the alias

krishnarx · 2026-07-29T10:12:58Z

Hi @ckbo3hrk — following up on the alias question from #15137. Since we confirmed the hyperbrainz alias in adkernelBidAdapter.js is unused on our side and safe to remove, could you go ahead and remove it? Patrick has flagged this as a blocker for getting our new adapter (#15405) merged. Let me know once it's done or if you need anything else from us.

patmmccann · 2026-07-31T16:08:39Z

@krishnarx the alias is fixed, we still need types on your params eg #14918

krishnarx and others added 10 commits June 18, 2026 15:12

HyperBrainz Bid Adapter: new adapter

12f06f7

Merge branch 'master' into hyperbrainz-bid-adapter-agent

40615a6

fix(hyperbrainz): resolve multi-format mtype detection, forward GPP c…

06b4b57

…onsent, remove navigator access, add onBidBillable handler

Merge branch 'master' into hyperbrainz-bid-adapter-agent

1a8e97e

fix: align contentType assertion with text/plain to avoid CORS preflight

f8f1a4d

docs: document userId param and endpoint config override

e78b642

Merge branch 'master' into hyperbrainz-bid-adapter-agent

7c92c80

Merge branch 'prebid:master' into hyperbrainz-bid-adapter-agent

c8544e9

fix: remove incorrect nurl-to-vastUrl mapping causing VAST playback f…

f50597a

…ailure

Merge branch 'hyperbrainz-bid-adapter-agent' of https://github.com/hy…

3096095

…perbrainz/Prebid.js into hyperbrainz-bid-adapter-agent

review-assignment-bot Bot requested a review from lksharma July 28, 2026 21:11

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

fix: update video bid test for nurl/vastUrl fix

5b0fa5c

patmmccann added the feature label Jul 28, 2026

ckbo3hrk mentioned this pull request Jul 29, 2026

Adkernel Bid Adapter: remove obsolete aliases #15409

Merged

1 task

krishnarx added 4 commits July 31, 2026 16:31

feat: add TypeScript type declarations for hyperbrainzBidAdapter

92dee1c

feat: add TypeScript type declarations for hyperbrainzBidAdapter

906160b

fix: add trailing newline to d.ts file

deaa915

Merge branch 'master' into hyperbrainz-bid-adapter-agent

38b7320

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HyperBrainz Bid Adapter: new adapter - #15405

HyperBrainz Bid Adapter: new adapter#15405
krishnarx wants to merge 15 commits into
prebid:masterfrom
hyperbrainz:hyperbrainz-bid-adapter-agent

krishnarx commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 28, 2026

Uh oh!

chatgpt-codex-connector Bot Jul 28, 2026

Uh oh!

chatgpt-codex-connector Bot Jul 28, 2026

Uh oh!

barecheck Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

patmmccann commented Jul 28, 2026 •

edited

Loading

Uh oh!

krishnarx commented Jul 29, 2026

Uh oh!

patmmccann commented Jul 31, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

krishnarx commented Jul 28, 2026

Type of change

Description of change

Other information

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

barecheck Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Barecheck - Code coverage report

Uh oh!

patmmccann commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krishnarx commented Jul 29, 2026

Uh oh!

patmmccann commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

barecheck Bot commented Jul 28, 2026 •

edited

Loading

patmmccann commented Jul 28, 2026 •

edited

Loading

patmmccann commented Jul 31, 2026 •

edited

Loading