Skip to content

Yaleo Bid Adapter: support configurable endpoint via config - #15397

Merged
patmmccann merged 1 commit into
prebid:masterfrom
alexandr-kim-vl:feature/yaleo-endpoint-parameter
Jul 28, 2026
Merged

Yaleo Bid Adapter: support configurable endpoint via config#15397
patmmccann merged 1 commit into
prebid:masterfrom
alexandr-kim-vl:feature/yaleo-endpoint-parameter

Conversation

@alexandr-kim-vl

Copy link
Copy Markdown
Contributor

Type of change

  • Updated bidder adapter

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Makes the bidder endpoint configurable via pbjs.setConfig({ yaleo: { endpoint } }), defaulting to the production URL when unset.

Other information

Docs PR: prebid/prebid.github.io#6683

@github-actions

Copy link
Copy Markdown

This PR includes an adapter whose code does not match its file name. Bid adapter modules should be named <bidderCode>BidAdapter, userId <userIdCode>IdSystem, RTD <rtdCode>RtdProvider, and analytics <analyticsCode>AnalyticsAdapter.

@review-assignment-bot
review-assignment-bot Bot requested a review from osazos July 28, 2026 09:31

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a7199b595e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread modules/yaleoBidAdapter.ts Outdated
@barecheck

barecheck Bot commented Jul 28, 2026

Copy link
Copy Markdown

Barecheck - Code coverage report

Total: 96.63%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@alexandr-kim-vl
alexandr-kim-vl marked this pull request as draft July 28, 2026 09:55
@alexandr-kim-vl
alexandr-kim-vl force-pushed the feature/yaleo-endpoint-parameter branch from a7199b5 to e0a3e40 Compare July 28, 2026 10:49
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

  • Changes to modules/yaleoBidAdapter.ts may need:
    • es.set.difference.v2
    • es.set.intersection.v2
    • es.set.is-disjoint-from.v2
    • es.set.is-subset-of.v2
    • es.set.is-superset-of.v2
    • es.set.symmetric-difference.v2
    • es.set.union.v2
    • esnext.set.difference.v2
    • esnext.set.intersection.v2
    • esnext.set.is-disjoint-from.v2
    • esnext.set.is-subset-of.v2
    • esnext.set.is-superset-of.v2
    • esnext.set.symmetric-difference.v2
    • esnext.set.union.v2

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

@alexandr-kim-vl
alexandr-kim-vl marked this pull request as ready for review July 28, 2026 10:52
@alexandr-kim-vl
alexandr-kim-vl marked this pull request as draft July 28, 2026 10:53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e0a3e40eab

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread modules/yaleoBidAdapter.ts Outdated
@alexandr-kim-vl
alexandr-kim-vl force-pushed the feature/yaleo-endpoint-parameter branch from e0a3e40 to 93891cf Compare July 28, 2026 10:56
@alexandr-kim-vl
alexandr-kim-vl marked this pull request as ready for review July 28, 2026 10:56
@alexandr-kim-vl
alexandr-kim-vl marked this pull request as draft July 28, 2026 11:01
@alexandr-kim-vl
alexandr-kim-vl force-pushed the feature/yaleo-endpoint-parameter branch from 93891cf to 5e5ad07 Compare July 28, 2026 11:15
@alexandr-kim-vl
alexandr-kim-vl marked this pull request as ready for review July 28, 2026 11:23
@patmmccann
patmmccann merged commit f101039 into prebid:master Jul 28, 2026
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants