Skip to content

New adapter: SMB - #15236

Merged
patmmccann merged 12 commits into
prebid:masterfrom
SmartBid-ai:master
Jul 25, 2026
Merged

New adapter: SMB#15236
patmmccann merged 12 commits into
prebid:masterfrom
SmartBid-ai:master

Conversation

@teqblaze

Copy link
Copy Markdown
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

doc MR: prebid/prebid.github.io#6640

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8846548933

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread modules/SMBBidAdapter.ts Outdated
@barecheck

barecheck Bot commented Jun 25, 2026

Copy link
Copy Markdown

Barecheck - Code coverage report

Total: 96.59%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@teqblaze

teqblaze commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Hi, @jsnellbaker ! Can you please check if everything is ok with PR

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Some adapters in this PR do not follow Prebid naming conventions.
Module SMBBidAdapter defines bidder code SMB, which contains uppercase or non-alphanumeric characters

@github-actions

Copy link
Copy Markdown

Some adapters in this PR do not follow Prebid naming conventions.
Module SMBBidAdapter defines bidder code SMB, which contains uppercase or non-alphanumeric characters

@teqblaze

Copy link
Copy Markdown
Contributor Author

Hi, @jsnellbaker! Can you please check this PR? Is the name "SMB" a problem?

@teqblaze

Copy link
Copy Markdown
Contributor Author

Hi, @patmmccann! Can you also please check this PR. Is everything okay with it?

Comment thread modules/SMBBidAdapter.ts Outdated
@teqblaze
teqblaze requested a review from patmmccann July 20, 2026 05:38
@github-actions

Copy link
Copy Markdown

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • test/spec/modules/SMBBidAdapter_spec.js (+1 error)

@github-actions

Copy link
Copy Markdown

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

  • Changes to test/spec/modules/smbBidAdapter_spec.js may need:
    • es.iterator.constructor
    • es.iterator.map
    • esnext.iterator.constructor
    • esnext.iterator.map

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

@teqblaze

Copy link
Copy Markdown
Contributor Author

Hi, @patmmccann! Can you please check again.

@jsnellbaker jsnellbaker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patmmccann
patmmccann merged commit b49abe1 into prebid:master Jul 25, 2026
99 checks passed
MartinGumGum added a commit to gumgum/Prebid.js that referenced this pull request Jul 27, 2026
…d-failures

* master:
  Axonix Bid Adapter - Modernize Refactor for 2026 (prebid#15234)
  WURFL RTD: report configurable caps in beacon via wurfl_caps (prebid#15293)
  Blue Bid Adapter: remove GVL ID (prebid#15392)
  GumGum Bid Adapter: add growthcode.io to pubProvidedId allowlist (prebid#15384)
  Module EightPod Adapter: update bid and analytics adapters (prebid#15253)
  New adapter: SMB (prebid#15236)
  HyperBrainz Bid Adapter: new adapter (prebid#15137)
  New Module: DAA AdChoices Signal (prebid#15138)
  gamAdServerVideo: Add GPP consent information to the DFP video url (prebid#13761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants