Copper6 adapter: change utility suite by anna-y-perion · Pull Request #14991 · prebid/Prebid.js

anna-y-perion · 2026-06-04T06:52:43Z

Type of change

Description of change

Other information

We have received the following email that approves start of our maintenance:
Perion Mail - Fwd_ Copper6 Prebid Adapter - now Operated by Vidazoo _ Perion.pdf

Related PRs:
prebid/prebid.github.io#6597
prebid/prebid-server#4812

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee4645d5a1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

patmmccann · 2026-06-04T10:48:41Z

+        bids: [
+            {
+                bidder: 'copper6ssp',
+                params: {


What are these params, it seems In order to not break existing integrations you'll need to figure out some sort of translation layer

We explain this params in Documentation
https://github.com/prebid/prebid.github.io/pull/6597/changes
We have added these type recently
@typedef {import('./copper6sspBidAdapter.d.ts').Copper6SSPBidRequestParams} Copper6SSPBidRequestParams
I thought that this file was requested for additional clarity of the code.
Also I have changed the "ext" object and added comment to have some explanation. Do you think it is clearer now?

your doc file has the wrong name, you can't force pubs to change params in a minor version so you should figure out how to translate what they do now to what you want

I see. I will work on it. Thank you

@patmmccann we have internal discussion and have talked to Copper6 team to understand the impact on the partners that use the adapter. Copper6 team took responsibility of the requested change. The request initially came from them and they will manage all publishers accordingly. Please see the attached conversation.
Can it be possible from this perspective to approve the change we want to make in minor version?

Hi @patmmccann
Is there any chance that the awareness of the partner from Copper6 (see my previous comment) can make this pr appropriate for a minor version?
If not - do you have any idea when v12 is expected to be published?

Even if they made it themselves, the issue is it is breaking; why doesn't perion do a server side translation of the requests without the required params? If there's only 18 pubs, surely you can ease their pain by inferring a cid and pid server side from their referer URL and placementId?

We expect to publish v12 in May or June of 2027

@patmmccann
We had find the way to accept old style bid requests on our end and changed the adapter accordingly.
We do not want to wait till the v12. :)
Please review.

barecheck · 2026-06-08T07:42:11Z

Barecheck - Code coverage report

Total: 96.61%

Your code coverage diff: 0.01% ▴

Uncovered files and lines

File	Lines
libraries/vidazooUtils/bidderUtils.js	127
test/spec/modules/copper6sspBidAdapter_spec.js	214

…s for copper6ssp bid adapter

# Conflicts: # test/spec/modules/copper6sspBidAdapter_spec.js

github-actions · 2026-07-09T11:33:42Z

Tread carefully! This PR adds 5 linter errors (possibly disabled through directives):

libraries/vidazooUtils/bidderUtils.js (+1 error)
modules/copper6sspBidAdapter.js (+4 errors)

github-actions · 2026-07-09T11:34:15Z

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

Changes to modules/copper6sspBidAdapter.js may need:
- es.iterator.constructor
- es.iterator.map
- esnext.iterator.constructor
- esnext.iterator.map
Changes to test/spec/modules/copper6sspBidAdapter_spec.js may need:
- es.array.with
- es.json.stringify
- esnext.array.with

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

github-actions · 2026-07-09T11:40:34Z

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

Changes to modules/copper6sspBidAdapter.js may need:
- es.iterator.constructor
- es.iterator.map
- esnext.iterator.constructor
- esnext.iterator.map
Changes to test/spec/modules/copper6sspBidAdapter_spec.js may need:
- es.array.with
- es.json.stringify
- esnext.array.with

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

anna-y-perion · 2026-07-19T09:14:33Z

@patmmccann
We had bypass the problem in mapping old adapter's fields to the new request.
Please review.

github-actions · 2026-07-20T11:51:00Z

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

Changes to modules/copper6sspBidAdapter.js may need:
- es.iterator.constructor
- es.iterator.map
- esnext.iterator.constructor
- esnext.iterator.map
Changes to test/spec/modules/copper6sspBidAdapter_spec.js may need:
- es.array.with
- es.json.stringify
- esnext.array.with
- esnext.json.parse

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

github-actions · 2026-07-27T06:18:46Z

This PR includes an adapter whose code does not match its file name. Bid adapter modules should be named <bidderCode>BidAdapter, userId <userIdCode>IdSystem, RTD <rtdCode>RtdProvider, and analytics <analyticsCode>AnalyticsAdapter.

anna-y-perion · 2026-07-27T06:31:56Z

@lksharma @patmmccann
Please help to understand if the change we introduced can be merged in minor version.
Please help us to understand how we can push the change so our partner can start work with us ASAP.
Related prs:
prebid/prebid.github.io#6597
prebid/prebid-server#4812

patmmccann · 2026-07-27T16:14:37Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48d8df4851

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-27T16:18:03Z

-
-  isBidRequestValid: isBidRequestValid(),
-  buildRequests: buildRequests(AD_URL),
+  isBidRequestValid,


Validate legacy params before normalizing them

For existing publishers using the previously documented placementId/endpointId parameters, core calls isBidRequestValid before buildRequests, and this imported validator requires both cId and pId. Those bids are therefore discarded before legacySupport can translate the legacy fields or apply its defaults, so the added compatibility path is unreachable during a real auction; the validator must accept the legacy forms that the build wrapper handles.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-27T16:18:03Z

@@ -0,0 +1,9 @@
+import { VidazooBaseBidderParams } from "../libraries/vidazooUtils/vidazooTypes.ts";
+
+export type Copper6SSPBidRequestParams = VidazooBaseBidderParams;


Preserve legacy params in the exported type

For TypeScript publishers retaining the adapter's existing configuration, aliasing this interface to VidazooBaseBidderParams makes cId and pId mandatory, omits endpointId, and permits placementId only as a number. Consequently previously valid placementId/endpointId string configurations now fail type checking even though the implementation explicitly attempts to support them; model the legacy and new parameter shapes as a union.

AGENTS.md reference: AGENTS.md:L60-L60

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-27T16:18:04Z

+}
+
+function legacySupport(createDomain, createUniqueRequestData, storage, BIDDER_CODE, BIDDER_VERSION, allowSingleRequest = false) {
+  const buildFunction = createBuildRequestsFn(createDomain, createUniqueRequestData, storage, BIDDER_CODE, BIDDER_VERSION, allowSingleRequest);


Declare the newly persisted deal identifier

Every Copper6 request now passes this storage manager into createBuildRequestsFn, whose shared request builder calls getUniqueDealId and persists a page-derived identifier under u_<hash>. The repository's generated Copper6 metadata currently records no disclosures from https://ssp.copper6.com/deviceStorage.json, and the module documentation does not describe this storage, so this newly introduced identifier needs the required device-storage disclosure and documentation before the adapter ships.

AGENTS.md reference: AGENTS.md:L75-L75

Useful? React with 👍 / 👎.

Fix will be set in the relevant json page.

patmmccann · 2026-07-27T16:23:48Z

@anna-y-perion my tooling is suggesting the param conversion needs a bit of work

anna-y-perion · 2026-07-28T08:46:03Z

@patmmccann thank you very much for the review.
"Validate legacy params before normalizing them" and "Preserve legacy params in the exported type" were implemented and relevant tests were added.

override Copper6 adapter

ee4645d

review-assignment-bot Bot requested a review from lksharma June 4, 2026 06:55

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread modules/copper6BidAdapter.d.ts Outdated

This was referenced Jun 4, 2026

Copper6 Adapter - adding document prebid/prebid.github.io#6597

Open

Copper6SSP: Override existing server prebid/prebid-server#4812

Open

Anna Yablonsky added 3 commits June 4, 2026 10:07

fix

368b665

name fix

484ae15

fix name of types

c4bb9bd

patmmccann reviewed Jun 4, 2026

View reviewed changes

Comment thread modules/copper6sspBidAdapter.js

patmmccann changed the title ~~override Copper6 adapter~~ Copper6 adapter: change utility suite Jun 5, 2026

patmmccann reviewed Jun 5, 2026

View reviewed changes

Comment thread modules/copper6sspBidAdapter.md Outdated

some additional explanation in types

dbcc625

review-assignment-bot Bot added the core label Jun 8, 2026

Anna Yablonsky added 2 commits June 8, 2026 10:28

Merge branch 'master' into adapter-copper6

d5936a5

adding some clarity to the md file about bids ext object

c36c8ca

patmmccann added 12.0 API Change and removed core labels Jun 15, 2026

Anna Yablonsky added 2 commits July 9, 2026 14:29

adding map for legacy params to support publishers that use old param…

20e8020

…s for copper6ssp bid adapter

Merge branch 'master' into adapter-copper6

255fc29

# Conflicts: # test/spec/modules/copper6sspBidAdapter_spec.js

review-assignment-bot Bot added the core label Jul 9, 2026

lint fixes

50ab3f8

anna-y-perion requested a review from patmmccann July 12, 2026 11:57

patmmccann mentioned this pull request Jul 18, 2026

LunamediaHB Bid Adapter: transfer maintenance to Ferio #15099

Open

1 task

Merge branch 'master' into adapter-copper6

fe770c3

Merge branch 'master' into adapter-copper6

48d8df4

chatgpt-codex-connector Bot reviewed Jul 27, 2026

View reviewed changes

patmmccann self-assigned this Jul 27, 2026

patmmccann removed 12.0 API Change core labels Jul 27, 2026

FIX - Validate legacy params before normalizing them

db838bd

review-assignment-bot Bot added the core label Jul 28, 2026

FIX - Preserve legacy params in the exported type

c9d0abd

patmmccann removed the core label Jul 28, 2026

patmmccann approved these changes Jul 28, 2026

View reviewed changes

patmmccann merged commit c86964f into prebid:master Jul 28, 2026
99 checks passed

		@@ -0,0 +1,9 @@
		import { VidazooBaseBidderParams } from "../libraries/vidazooUtils/vidazooTypes.ts";

		export type Copper6SSPBidRequestParams = VidazooBaseBidderParams;

Uh oh!

Conversation

anna-y-perion commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Other information

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

patmmccann Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

anna-y-perion Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patmmccann Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

anna-y-perion Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

anna-y-perion Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anna-y-perion Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

patmmccann Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patmmccann Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

anna-y-perion Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

barecheck Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Barecheck - Code coverage report

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

anna-y-perion commented Jul 19, 2026

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 27, 2026

Uh oh!

anna-y-perion commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patmmccann commented Jul 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 27, 2026

Choose a reason for hiding this comment

anna-y-perion commented Jun 4, 2026 •

edited

Loading

anna-y-perion Jun 8, 2026 •

edited

Loading

anna-y-perion Jun 22, 2026 •

edited

Loading

patmmccann Jun 30, 2026 •

edited

Loading

anna-y-perion Jul 9, 2026 •

edited

Loading

barecheck Bot commented Jun 8, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading

anna-y-perion commented Jul 27, 2026 •

edited

Loading