Skip to content

45 sensory level refactor - #47

Merged
EddieMachete merged 5 commits into
masterfrom
45-sensory-level-refactor
Feb 19, 2026
Merged

45 sensory level refactor#47
EddieMachete merged 5 commits into
masterfrom
45-sensory-level-refactor

Conversation

@EddieMachete

@EddieMachete EddieMachete commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Closes #45

Adds step-based logic implementing the chain-of-command pattern in file src/classification/neurologicalLevels/sensoryLevel.ts

@EddieMachete
EddieMachete requested a review from Copilot February 18, 2026 21:57
@EddieMachete EddieMachete self-assigned this Feb 18, 2026
@EddieMachete EddieMachete added the enhancement New feature or request label Feb 18, 2026
@EddieMachete
EddieMachete marked this pull request as ready for review February 18, 2026 21:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors sensory level classification to a step-based (chain-of-command) flow so the algorithm can emit structured “steps” (description/actions/state) alongside preserving the existing determineSensoryLevel entry point.

Changes:

  • Refactors determineSensoryLevel into a step-chain with a new sensoryLevelSteps() generator.
  • Introduces domain-specific SensoryLevelError and centralized error message constants.
  • Adds English translation keys for sensory level step descriptions/actions and expands unit test coverage for the new entry points.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
src/en.ts Adds translation keys for sensory level step tracing; reformats existing strings.
src/classification/neurologicalLevels/sensoryLevelErrors.ts Adds centralized sensory level error codes/messages and a domain error type.
src/classification/neurologicalLevels/sensoryLevel.ts Implements step-based sensory level calculation + generator; updates error throwing.
src/classification/neurologicalLevels/sensoryLevel.spec.ts Adds tests for new entry points and error type; refactors existing test formatting.
docs/sensoryLevel-architecture.md Documents the intended step-based architecture and translation keys.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/en.ts Outdated
Comment thread src/en.ts Outdated
Comment thread src/classification/neurologicalLevels/sensoryLevel.ts Outdated
Comment thread src/classification/neurologicalLevels/sensoryLevelErrors.ts Outdated
Comment thread src/classification/neurologicalLevels/sensoryLevel.spec.ts Outdated
Comment thread docs/sensoryLevel-architecture.md Outdated
Comment thread src/classification/neurologicalLevels/sensoryLevel.ts Outdated
Comment thread src/en.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/classification/neurologicalLevels/sensoryLevel.spec.ts Outdated
Comment thread src/classification/neurologicalLevels/sensoryLevel.ts
EddieMachete and others added 2 commits February 18, 2026 17:36
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@EddieMachete EddieMachete linked an issue Feb 19, 2026 that may be closed by this pull request
@EddieMachete
EddieMachete merged commit 43ff3af into master Feb 19, 2026
2 checks passed
@EddieMachete
EddieMachete deleted the 45-sensory-level-refactor branch February 25, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sensory level refactor

2 participants