[FIX] Prawn 2.4.0 Compatibility#34
Conversation
|
we are using this branch with Rails 7.x is it possible to get it reviewed and released? thanks |
|
I am not maintaing this repo, nor do I know the codebase, but reviewing your PR makes me want to drop some comments/suggestons: The code changes in your commit aren't self-explanatory, so I went to see if the commit message explains it better. Unfortunately the commit message is completely meaningless. Thus, I don't understand your changes. You're changing an expectation in a test case. Why, and it doesn't really seem related to making it compatible with Prawn 2.4.0, is it? I think you should really provide some explanation. Maybe start with how it's currently not compatible with Prawn 2.4.0 and then what you're changing in order to achieve compatibility. Thank you for considering my suggestions! |
Based on upstream PR prawnpdf#34. Prevents mutating shared dictionary data when adding content streams, which caused corruption when the same page dictionary was referenced from multiple places. Generated with Claude Code
3 participants
No description provided.