Repository navigation
Conversation
Requires ppy/osu#39009. Rank is being displayed in the Lustrous tier badges, and we also want to display the progress towards calibrating ranks, so both of these need to be provided to the client on lobby join.
smoogipoo
requested changes
Oct 20, 2026
| string variantString = string.Empty; | ||
|
|
||
| if (withRank) | ||
| variantString = ", (SELECT COUNT(*) FROM `matchmaking_user_stats` AS `mus` WHERE `plays` > 0 AND `sigma` < 100 AND `rating` > `matchmaking_user_stats`.`rating` AND `pool_id` = `matchmaking_user_stats`.`pool_id`) AS `rank`"; |
Contributor
There was a problem hiding this comment.
Should be SELECT COUNT(*) + 1, right?
smoogipoo
pushed a commit
to ppy/osu
that referenced
this pull request
Oct 22, 2026
smoogipoo
approved these changes
Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires ppy/osu#39009.
Rank is being displayed in the Lustrous tier badges, and we also want to display the progress towards calibrating ranks, so both of these need to be provided to the client on lobby join.