Skip to content

fix: Liquid tags in HTML comment broke the homepage <head> #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ppgranger merged 1 commit into from
Aug 9, 2026
Merged

fix: Liquid tags in HTML comment broke the homepage <head> #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions docs/_includes/head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!--
{% comment %}
Full override of minima's _includes/head.html.

minima ships a `custom-head.html` extension point, but only from some
Expand All @@ -11,10 +11,15 @@
minima version Pages happens to be running.

Everything up to the closing </head> mirrors minima 2.5.1's head.html
(meta tags, {% seo %}, stylesheet, feed_meta, conditional Google
Analytics) so nothing else regresses; the JSON-LD block is the only
addition.
-->
(meta tags, seo tag, stylesheet, feed_meta, conditional Google Analytics)
so nothing else regresses; the JSON-LD block is the only addition.

This has to be a Liquid {% comment %} block, not an HTML <!-- --> comment:
Liquid tags are evaluated wherever they appear, even inside HTML comments,
and {% seo %} below renders its own "<!-- End Jekyll SEO tag -->" — whose
"-->" would close an HTML comment early and leak the rest of this text
(plus a duplicate <head>) straight into the rendered page.
{% endcomment %}
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
Expand Down