fix(adapter-sql-js): Updated sql-js upstream version to support rust sync implementation - #681
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 69a160a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chriztiaan
marked this pull request as ready for review
July 31, 2025 14:18
stevensJourney
approved these changes
Jul 31, 2025
Contributor
|
So if I understand correctly, the issue is that we're passing an ArrayBuffer, while upstream sql-js only supports Uint8Array? This probably comes up because we're explicitly converting from Uint8Array to ArrayBuffer here, and now we're effectively converting back to Uint8Array. I wonder if we should modify that check, to keep the |
whygee-dev
pushed a commit
to whygee-dev/powersync-js
that referenced
this pull request
Oct 18, 2025
…sync implementation (powersync-ja#681)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small dependency bump for adapter-sql-js package.
See upstream change powersync-ja/powersync-sql-js#5