fix(react): forward throttleMs from useQuery to the watched query - #1084
Open
icole wants to merge 2 commits into
Open
fix(react): forward throttleMs from useQuery to the watched query#1084icole wants to merge 2 commits into
icole wants to merge 2 commits into
Conversation
useQuery accepts throttleMs in its options type but the object it builds for useWatchedQuery only carries reportFetching and rowComparator, so the value never arrives and the default 30ms throttle always applies. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 6ecd531 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Covers both branches of useWatchedQuery: the standard `watch` path and the `differentialWatch` path taken when a rowComparator is supplied. Both spy on the watched query construction and assert the option arrives, rather than timing throttle windows, which would be flaky on CI. Verified to fail without the one-line fix in useQuery.ts (all four matrix cases report `expected undefined to deeply equal 1234`). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1082.
useQueryacceptsthrottleMsin its options type, but the object it builds foruseWatchedQueryonly carriesreportFetchingandrowComparator, so the value never arrives and you always get the 30ms default.useWatchedQueryalready readshookOptions.throttleMsin three places, so it's just the one missing property.The other thing I mentioned in the issue is left alone here:
tablesandtriggerImmediatealso type-check on the hook and are also dropped, andtriggerOnTablesisn't reachable through it at all. That's the options type inheriting from the callback API rather than the watched-query one, and untangling it is a breaking change, so it seemed like your call rather than something to fold in.