ci: add pre-merge quality gates#951
Draft
jdyaberi-pp wants to merge 3 commits into
Draft
Conversation
Extend the PR workflow with pre-commit/clippy, integrations and UI build jobs, a FalkorDB-backed graph e2e suite, and benchmark harness unit tests so regressions are caught before merge. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Run pre-commit only on changed files instead of the full repo, fix the integrations job working directory, and use a catalog-safe DEPENDS_ON edge in the FalkorDB server round-trip test. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop strict cargo clippy (-D warnings) until existing parsing warnings are addressed, run integrations unit tests only while legacy HTTP mounts still import removed context-graph Celery handlers, and run legacy pytest via the legacy project env for correct database drivers. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qualityjob that runs pre-commit across the repo andcargo clippyfor parsingintegrations,ui-build,graph-e2e(FalkorDB server + Postgres), andbenchmark-smokejobs to the regression workflowTest plan
qualityjob passes (pre-commit + clippy)integrationsjob passes with Postgres serviceui-buildjob builds the graph-explorer SPAgraph-e2ejob passes against the FalkorDB service containerbenchmark-smokejob passes (pytest tests/unit/benchmarks/)Made with Cursor