Update proxy.go to add streaming response - #1
Open
Lacuranas wants to merge 1 commit into
Open
Conversation
Changes:
Replaced io.ReadAll() in ServeHTTP with a chunked reading loop.
Implemented io.MultiWriter to simultaneously stream the response to the client and copy it into a local buffer for metric extraction.
Added http.Flusher support to ensure that chunks are pushed to the client immediately without being buffered by Go's HTTP server.
Metrics are now extracted from the accumulated buffer after the stream has finished, maintaining compatibility with existing extractMetrics logic.
Impact:
Users can now experience real-time token streaming (the "typing" effect) while the proxy continues to track token usage and latency for Prometheus metrics in the background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Replaced io.ReadAll() in ServeHTTP with a chunked reading loop.
Implemented io.MultiWriter to simultaneously stream the response to the client and copy it into a local buffer for metric extraction.
Added http.Flusher support to ensure that chunks are pushed to the client immediately without being buffered by Go's HTTP server.
Metrics are now extracted from the accumulated buffer after the stream has finished, maintaining compatibility with existing extractMetrics logic.
Impact:
Users can now experience real-time token streaming (the "typing" effect) while the proxy continues to track token usage and latency for Prometheus metrics in the background.