Add Windows build support (MSVC) and fix test portability - #1
Merged
Conversation
davecramer
commented
Jul 2, 2026
davecramer
commented
Contributor
- Add tests/test_platform.h with cross-platform dlopen/dlsym/dlclose macros mapping to LoadLibrary/GetProcAddress/FreeLibrary on Windows
- Fix test files to include windows.h before sql.h (required by MSVC)
- Replace bare dlfcn.h includes with test_platform.h
- Add dsn_config_read_file() for file-based DSN reading in tests; uses GetPrivateProfileStringA on Windows since SQLGetPrivateProfileString always reads from registry regardless of filename argument
- Update CI workflow: install pkgconf via pip, generate native.ini to work around Meson rejecting Strawberry Perl pkg-config on Windows
- Add tests/test_platform.h with cross-platform dlopen/dlsym/dlclose macros mapping to LoadLibrary/GetProcAddress/FreeLibrary on Windows - Fix test files to include windows.h before sql.h (required by MSVC) - Replace bare dlfcn.h includes with test_platform.h - Add dsn_config_read_file() for file-based DSN reading in tests; uses GetPrivateProfileStringA on Windows since SQLGetPrivateProfileString always reads from registry regardless of filename argument - Update CI workflow: install pkgconf via pip, generate native.ini to work around Meson rejecting Strawberry Perl pkg-config on Windows
…om PATH The choco PostgreSQL package ships a libpq.pc with the build machine's prefix baked in (D:/a/postgresql-packaging-foundation/...). Rewrite it to point to the actual install location. Also remove Strawberry Perl from PATH since it injects ccache (which wraps cl.exe) and a broken pkg-config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.