Remove orphaned integration folders#813
Merged
Merged
Conversation
integration-testing/ was a docker-compose harness for bats/cypress suites that were removed long ago; CI now runs the pytest suite via the posit-dev/with-connect action (#739). integration/jwt_testbed.py was a manual, non-CI script exercising a live server's bootstrap authorization responses — server-side behavior outside this CLI's scope. The client-side JWT signing this tool is responsible for stays covered by tests/test_json_web_token.py. Drop the now-unused ruff exclude.
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes three top-level folders with defunct tests, and adds a small guard test for the bootstrap JWT constants.
integration-testing/— adocker-composeharness that built bats/cypress suites which were removed long ago. CI now runs the pytest suite via theposit-dev/with-connectaction (ci: use with-connect for integration testing against many versions of Connect #739); nothing invokes this compose setup.integration/jwt_testbed.py— a manual, non-CI script that POSTed to a live server's bootstrap endpoint to check authorization responses. That is server-side behavior outside this CLI's scope. The client-side JWT signing this tool is responsible for remains covered bytests/test_json_web_token.py."integration"entry from ruff'sextend-excludeinpyproject.toml.TestBootstrapContracttotests/test_json_web_token.py, pinningDEFAULT_ISSUER/DEFAULT_AUDIENCE/BOOTSTRAP_SCOPEto their literal values so a change to these wire-contract constants can't slip through unnoticed.Why
Neither folder is referenced by CI, the Justfile, docs, or scripts. They're dead scaffolding; keeping them invites confusion about what actually runs.
Verification
just lint— clean.test_quickstart.pyfailures are an unrelated localorjson/maturin build issue.)