Follow symlinks when building bundle#546
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
I played around with Windows and it's pretty weird. The good news is symlinks work fine, the command is They're not supported on FAT filesystems but that's probably OK for our purposes. However, by default, you don't have permissions to call |
So true 😆 Weird but this is fine to merge, @jcheng5? Even if you're not an admin, you can still follow symlinks, right? |
aa3a496 to
272241f
Compare
|
I have NOT tested this on Windows, only Mac. Please nobody merge until I've tested.
Intent
Fixes #414. When building a bundle, follow symlinks. This allows apps to include directories that might live somewhere else for deduplication/centralization reasons.
Type of Change
Approach
os.walktakes afollowlinksargument that defaults toFalse. I simply set this toTrue. Note that from googling,os.walkdoesn't check for circular references--I'm happy to add that if we think it's important.Automated Tests
TODO
Directions for Reviewers
Create two sibling directories, one called
dataand one calledshinytest.shinytest/app.py:
data/message.txt:
Then, from within the shinytest directory, run
ln -s ../data data.Deploy from within the shinytest directory as usual, and see if it crashes on startup or the message correctly appears instead.
Checklist