PB-14077: Grant px-backup RBAC to read kdmp-config ConfigMap#927
Open
wdhopte-px wants to merge 2 commits into
Open
PB-14077: Grant px-backup RBAC to read kdmp-config ConfigMap#927wdhopte-px wants to merge 2 commits into
wdhopte-px wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cluster-scoped configmaps 'get' permission to px-backup-cluster-role
so that px-backup can read the kdmp-config ConfigMap in kube-system
namespace. This is required for the KDMP PriorityClass feature where
the PriorityClassName for KDMP job pods is read from the
KDMP_JOB_PRIORITY_CLASS_NAME key in the kdmp-config ConfigMap.
Without this permission, delete and maintenance jobs created by
px-backup fail to read the PriorityClass configuration.