Alter operation grouping to minimise number of jobs - #260
Merged
Conversation
…e, process multiple genes while the MT is loaded
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the gene group file generation process to reduce the number of batch jobs by grouping multiple genes into single jobs instead of creating one job per gene.
- Batches multiple genes (default 50) into single jobs to reduce batch system overhead
- Modifies the
make_group_filefunction to process multiple genes in one execution - Loads the chromosome matrix table once per job and processes all genes in that batch
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
annacuomo
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change mirrors the approach here: https://github.com/populationgenomics/saige-tenk10k/blob/main/saige_assoc_set_test.py#L275-L282
make_group_fileare the gene name and the output file, all other arguments are constant across the whole chromosomeHopefully this brings down the number of jobs involved.