Skip to content

revert: remove scheduler overhead tolerance #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerome-benoit merged 1 commit into from
Jul 4, 2026
+2 −7
Merged

revert: remove scheduler overhead tolerance #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions tests/pools/abstract-pool.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1590,14 +1590,9 @@ describe({
await pool.destroy()
const elapsedTime = performance.now() - startTime
expect(tasksFinished).toBe(0)
// Worker kill message response timeout is 1000ms.
// Allow a small scheduler overhead margin on busy CI hosts.
const schedulerOverheadMargin = 100
// Worker kill message response timeout is 1000ms
expect(elapsedTime).toBeLessThanOrEqual(
tasksFinishedTimeout +
1000 * tasksFinished +
1000 +
schedulerOverheadMargin,
tasksFinishedTimeout + 1000 * tasksFinished + 1000,

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid an exact timer ceiling

This test now fails whenever the two timeout-based waits in destroyWorkerNode() overshoot by even a few milliseconds: waitWorkerNodeEvents(..., tasksFinishedTimeout, false) and the subsequent kill-message timeout both use setTimeout, and the CI workflow runs deno task test:coverage across Windows, macOS, Ubuntu, and multiple Deno versions. On a busy runner, an elapsed time like 2001ms is expected scheduler delay rather than a destroy() regression, so removing the small margin reintroduces a flaky CI failure.

Useful? React with 👍 / 👎.

)
})

Expand Down
Loading