Repository navigation
fix(workflow): validate imagekit publish on macOS where its tools exist - #17
Merged
Merged
Conversation
publish-imagekit ran the test gate on ubuntu-latest, where imagekit's macOS-native image ops (sips) and brew tools (exiftool, imagemagick, libavif, webp) are absent — the validate step failed 32/56 tests with 'sips not found'. Move the job to macos-26 and provision the tools, matching the CI harness validation that already passes.
There was a problem hiding this comment.
Pull request overview
This PR updates the publish-imagekit GitHub Actions workflow to run the publish/validation gate on a macOS runner and installs the macOS-specific image tooling needed for ImageKit’s validation suite (e.g., sips and Homebrew-provided utilities), addressing failures seen on Ubuntu runners.
Changes:
- Switch the publish job runner from
ubuntu-latesttomacos-26. - Add a conditional Homebrew install step for required image tooling (
exiftool,imagemagick,libavif,webp) before the validation gate.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish-imagekit ran the test gate on ubuntu-latest, where imagekit's macOS-native image ops (sips) and brew tools (exiftool, imagemagick, libavif, webp) are absent — the validate step failed 32/56 tests with 'sips not found'. Move the job to macos-26 and provision the tools, matching the CI harness validation that already passes.