Skip to content

Fix top issues: Proguard rules, iOS deprecation, and Windows crash - #585

Open
ponnamkarthik wants to merge 1 commit into
masterfrom
fix-top-issues-15828502520989948020
Open

Fix top issues: Proguard rules, iOS deprecation, and Windows crash#585
ponnamkarthik wants to merge 1 commit into
masterfrom
fix-top-issues-15828502520989948020

Conversation

@ponnamkarthik

Copy link
Copy Markdown
Owner

This PR addresses three of the top open issues on the repository:

  1. Issue [Critical] Toast not visible on production if your app enabled proguard #553: Added documentation to README.md explaining the required Proguard rules for Android release builds (-keep class io.github.ponnamkarthik.toast.** { *; }).
  2. Issue UIActivityIndicatorViewStyleWhiteLarge is deprecated: first deprecated in iOS 13.0 #535: Replaced the deprecated UIActivityIndicatorViewStyleWhiteLarge with UIActivityIndicatorViewStyleLarge for iOS 13+ in ios/fluttertoast/Sources/fluttertoast/UIView+Toast.m.
  3. Issue using Fluttertoast.cancel on windows will cause Unhandled Exception: MissingPluginException #562: Added a try/catch block for MissingPluginException in fluttertoast.dart to prevent unhandled exceptions when calling cancel() or showToast() on unsupported platforms like Windows.

PR created automatically by Jules for task 15828502520989948020 started by @ponnamkarthik

- Added Proguard rules to README.md (Fixes #553).
- Resolved UIActivityIndicatorViewStyleWhiteLarge deprecation warning on iOS 13+ (Fixes #535).
- Handled MissingPluginException on unsupported platforms like Windows (Fixes #562).

Co-authored-by: ponnamkarthik <19759716+ponnamkarthik@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant