Skip to content

Fix crash on macOS 26 when closing the splash window #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gklka wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix crash on macOS 26 when closing the splash window #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e662b9b
Fix crash on macOS 26 when closing the splash window
gklka May 30, 2026
3baa743
Also set releasedWhenClosed=NO on the splash window in its NIB
gklka May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Base.lproj/SplashWindow.xib
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</customObject>
<customObject id="-1" userLabel="First Responder" customClass="FirstResponder"/>
<customObject id="-3" userLabel="Application" customClass="NSObject"/>
<window title="Welcome to Add Folder Icons" allowsToolTipsWhenApplicationIsInactive="NO" autorecalculatesKeyViewLoop="NO" visibleAtLaunch="NO" animationBehavior="default" id="1">
<window title="Welcome to Add Folder Icons" allowsToolTipsWhenApplicationIsInactive="NO" autorecalculatesKeyViewLoop="NO" releasedWhenClosed="NO" visibleAtLaunch="NO" animationBehavior="default" id="1">
<windowStyleMask key="styleMask" titled="YES"/>
<windowPositionMask key="initialPositionMask" leftStrut="YES" rightStrut="YES" topStrut="YES" bottomStrut="YES"/>
<rect key="contentRect" x="196" y="240" width="800" height="500"/>
Expand Down
22 changes: 21 additions & 1 deletion SplashWindowController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,20 @@ - ( void ) windowDidLoad
{
[ super windowDidLoad ];

/* The main window's NIB sets "released when closed" to NO, but the splash
* window's NIB does not, so the splash window defaults to releasing itself
* on close. On modern macOS that is fatal: when the splash window is the
* key window and is closed, it is deallocated, yet AppKit's automatic
* focus-ring machinery still references it when first-responder status
* moves back to the main window. The result is a use-after-free crash in
* +[_NSAutomaticFocusRing _clearOldFocusRing] -> -[NSWindow
* _setNeedsDisplayInRegion:]. This controller owns the window for the
* lifetime of the application, so keep it alive on close, matching the
* behaviour already configured for the main window.
*/

[ [ self window ] setReleasedWhenClosed: NO ];

[ [ self window ] center ];
[ [ self window ] makeKeyAndOrderFront: nil ];
}
Expand All @@ -65,7 +79,13 @@ - ( void ) windowDidLoad
- ( IBAction ) closeWindow: ( NSButton * ) sender
{
( void ) sender;
[ self close ];

/* Resign first responder before the window goes away so that AppKit tears
* down any focus ring while the window is still a valid object.
*/

[ [ self window ] makeFirstResponder: nil ];
[ self close ];
}

@end