github: add a note about GitHub user ids

[calebdoxsey]

Summary

Add a note about node_id being used as user_id for GitHub.

Related

• ENG-4268

AI disclosure

none

Checklist

• reference any related issues
• disclosed AI usage (or wrote "none") per AI_POLICY.md

[netlify]

✅ Deploy Preview for pomerium-docs ready!

Name	Link
🔨 Latest commit	9f69920
🔍 Latest deploy log	https://app.netlify.com/projects/pomerium-docs/deploys/6a67d09d3fdc8300088b8224
😎 Deploy Preview	https://deploy-preview-2331--pomerium-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[greptile-apps]

Greptile Summary

Adds GitHub user-ID guidance for Pomerium 0.34.

• Explains that GitHub node_id replaces login as the Pomerium user_id.
• Provides a GitHub API command for retrieving a user's node_id.
• Capitalizes the existing “Getting Groups” heading.

Confidence Score: 4/5

The lookup command should be made failure-sensitive before merging so administrators cannot mistake null for a GitHub user ID.

GitHub error responses lack node_id, but the documented curl/jq pipeline converts that condition into successful output rather than clearly rejecting the lookup.

Files Needing Attention: content/docs/integrations/user-identity/github.mdx

Important Files Changed

Filename	Overview
content/docs/integrations/user-identity/github.mdx	Documents the GitHub user-ID transition, but the supplied lookup command silently emits null for error responses.

_{Reviews (1): Last reviewed commit: "add a note about GitHub user ids" | Re-trigger Greptile}

[greptile-apps]

Error responses become null IDs

When GitHub returns an error for an invalid login or failed request, this pipeline exits successfully and prints null, causing administrators to configure a user criterion that never matches. Red test: output="$(printf '%s\n' '{"message":"Not Found"}' | jq -r .node_id)"; test "$output" != null fails because the current jq expression accepts a missing field.

Suggested change

	curl -s https://api.github.com/users/USER_LOGIN | jq -r .node_id
	curl -fsS https://api.github.com/users/USER_LOGIN | jq -er .node_id

Context Used: For every finding, write a red test with proof and... (source)