Fix IONOS DNS record creation request format - #1243
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes IONOS DNS-01 certificate issuance by aligning the DNS record creation request payload with the IONOS DNS API contract (array payload), and improves usability by documenting the expected API key format across docs and deployment UI metadata.
Changes:
- Send IONOS DNS record creation payloads as an array (and batch multiple TXT values into a single request).
- Skip record creation when there are no TXT values to create.
- Document the required IONOS API key
<public-prefix>.<secret>format in reference docs, provider guide, and deployment UI tooltip.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Acmebot.App/Providers/IonosDnsProvider.cs | Switches record creation from single-object POST to array POST; batches multiple TXT records per request and adds minor HTTP response disposal/formatting improvements. |
| docs/reference/configuration.md | Clarifies IONOS API key format and links to official IONOS guidance. |
| docs/guide/dns-providers.md | Expands IONOS provider setup documentation and updates example env var format. |
| deploy/uiFormDefinition.json | Updates the IONOS API key tooltip to reflect the public-prefix.secret format. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
POST /zones/{zoneId}/recordsreceived a single record object even though the IONOS DNS API expects an array, causing certificate issuance to fail with HTTP 400.Impact
This restores DNS-01 certificate issuance for IONOS users and avoids partial updates when a challenge requires multiple TXT values.
Validation
dotnet test Acmebot.slnx --no-restore(218 tests passed)dotnet format Acmebot.slnx --verify-no-changes --no-restoreCloses #1242