Document Terraform v5 migration guidance - #1239
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the v4→v5 migration documentation to explicitly address Terraform-managed deployments, clarifying that the “in-place migration” guidance applies to an existing Function App deployment, not to the legacy Terraform module deployment model.
Changes:
- Adds a “Terraform Module Deployments” section clarifying the legacy
shibayan/keyvault-acmebot/azurermmodule is not eligible for the in-place migration steps. - Documents the recommended approach for Terraform users: deploy a fresh v5 Flex Consumption environment using the
polymind-inc/acmebot/azurermmodule and retire the v4 environment. - Notes Key Vault reuse via
acmebot.vault_uriand calls out the configuration areas that must be recreated/verified for the new deployment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The v4 and v5 Terraform modules have substantially different resource structures, so a Terraform state/import-based in-place migration is not supported. The migration guide should make the recommended re-setup path explicit.
Validation
npm run buildindocsCloses polymind-inc/terraform-azurerm-acmebot#35