Dispose the ACME client and signer when context creation fails

[shibayan]

Problem

AcmeClientFactory.CreateClientCoreAsync constructs an AcmeClient — which owns an HttpClient and its handler — and only afterwards fetches the directory and creates or loads the account. The result is assigned to the cached field via _clientContext ??= await CreateClientCoreAsync(), so it is only reachable on success.

Any failure in between leaves the client and the signer unreachable and undisposed:

• the directory fetch against an unreachable or misbehaving ACME endpoint
• the PreconditionException thrown when the endpoint requires EAB and none is configured
• an account creation failure or a state store write failure

Because CreateClientAsync is called from every activity, a persistently failing ACME endpoint accumulates one HttpClient and one SocketsHttpHandler per attempt for the lifetime of the worker.

Change

Wrap the construction in try/catch and dispose both the client and the signer on the failure path. AcmeClientContext.Dispose() disposes both, so the failure path is symmetric with the success path. The client is declared nullable so a throw from the AcmeClient constructor itself is covered too.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Improves reliability of AcmeClientFactory.CreateClientCoreAsync by ensuring resources created during client-context construction are disposed when context creation fails, preventing repeated HttpClient/handler leaks on persistent failures.

Changes:

• Wrap ACME client context construction in try/catch to dispose the AcmeClient and signer when intermediate steps fail.
• Make the AcmeClient local nullable to cover exceptions thrown during the client constructor.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.