fix: replace unsafe transmute with Request::from_ngx_http_request#15
Merged
Conversation
This fixes a critical memory safety issue that caused SIGSEGV crashes when processing OPTIONS requests. The issue was caused by unsafe mem::transmute assuming identical memory layouts between ngx_http_request_t and ngx::http::Request, which can break across different Nginx versions or compiler settings. Changes: - Replace mem::transmute with ngx-rust official API Request::from_ngx_http_request - Add null pointer checks before creating Request objects - Remove unnecessary unsafe keywords - Clean up temporary debugging scripts and test files - Update test configurations to match production environment - Bump version to 1.3.2 Fixes memory corruption in ngx_http_update_location_config when processing CORS preflight OPTIONS requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a critical memory safety issue that caused SIGSEGV crashes when processing OPTIONS requests. The issue was caused by unsafe mem::transmute assuming identical memory layouts between ngx_http_request_t and ngx::http::Request, which can break across different Nginx versions or compiler settings.
Changes:
Fixes memory corruption in ngx_http_update_location_config when processing CORS preflight OPTIONS requests.