Add RealtimeDelay for realtime clock support - #8
Open
saneki wants to merge 1 commit into
Open
Conversation
Very similar to `Delay` but uses a realtime clock with a provided `SystemTime` deadline and the `Abstime` flag when setting the timer. Other notes: - Declined to implement `RealtimeDelay::reset` to discourage desyncing the struct state with the potentially armed `timerfd` state. - `poll` may return an `io::Error` of kind `ErrorKind::Other` if `deadline` is before the Unix epoch. Reaching this requires the system's realtime clock to also be before the epoch for at least a short period of time so it may be impossible for this to actually occur, but I figured returning an `Err` was better than a panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
RealtimeDelayfor a oneshot timer operating on the realtime clock, which thetimerfdcrate provides support for. It is very similar toDelaybut uses aSystemTimedeadline and theAbstimeflag when setting the timer.Other notes:
RealtimeDelay::resetto discourage desyncing the struct state with the potentially armedtimerfdstate.pollmay return anio::Errorof kindErrorKind::Otherifdeadlineis before the Unix epoch. Reaching this requires the system's realtime clock to also be before the epoch for at least a short period of time so it may be impossible for this to actually occur, but I figured returning anErrwas better than a panic.