Remove dependency on futures-lite - #5
Open
chadaustin wants to merge 3 commits into
Open
Conversation
Owner
|
I think we should switch to https://doc.rust-lang.org/stable/std/task/macro.ready.html |
futures-lite is only used for a convenience macro and it's easy enough to inline it. This avoids pulling in futures-lite dependencies like fastrand and waker-fn, reducing the need for security updates. Separately, tokio's net feature is not needed, so remove it. Fixes polachok#3
chadaustin
force-pushed
the
remove-futures-lite
branch
from
December 5, 2024 00:00
b71861d to
a4d2cc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
futures-lite is only used for a convenience macro and it's easy enough to inline it. This avoids pulling in futures-lite dependencies like fastrand and waker-fn, reducing the need for security updates.
Separately, tokio's net feature is not needed, so remove it.
Before:
After:
Fixes #3