Lit with shadows shader now uses material parameters - #823
Open
prof-danielc wants to merge 1 commit into
Open
Conversation
Updated lit_with_shadows_shader.py to load material parameters and correctly display GLTF files that use materials instead of textures to color the model. For example: https://quaternius.com/packs/ultimateanimatedanimals.html
Contributor
|
@pokepetter looks small enough for a fix, But is Lit_with_Shadow_Shader actually for loading PBR materials ? Isn't it just for shadow ? SO MOST PROBABLY, this is redudent ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated lit_with_shadows_shader.py to load material parameters and correctly display GLTF files that use materials instead of textures to color the model.
For example, the fox model from:
https://quaternius.com/packs/ultimateanimatedanimals.html