Added Generic Type Hinting to Singleton Decorator! - #816
Conversation
| from ursina.camera import instance as camera | ||
| from ursina.mouse import instance as mouse | ||
| from ursina import entity | ||
| from ursina import shader |
There was a problem hiding this comment.
Are you sure it really needed to be removed from the imports?
There was a problem hiding this comment.
Ah! I'm sorry! I think I accidentally let my code formatter loose in main.py and wasn't paying enough attention when I made the PR. It must've alphabetically sorted the imports and removed ones it thought weren't necessary.
The formatter picked it up as unused but I don't know if there's some nuance it might be missing.
I'll re-add the missing imports. Sorry, I didn't mean to mess with main.py.
|
|
||
| try: | ||
| from ursina import gamepad | ||
| pass |
There was a problem hiding this comment.
Why is the pass specified here if the basic design does nothing?
|
@pokepetter Too many unnecessary commits for such a simple change. Maybe worthwile accepting if cleaned up. Otherwise, just close it. |
3 participants
A fix for the problem mentioned in #815 🙂