package import Foundation.NSData

[JanGorman]

This changes the package import Foundation in Deprecations.swift to a package import Foundation.NSData.

This solves the issue mentioned here #229 where the release build of our application was failing with errors like this one.

ambiguous implicit access level for import of 'Foundation'; it is imported as 'package' elsewhere
[11:36:26]: ▸ import class Foundation.Bundle

[mbrandonw]

Hi @JanGorman, I think there is another solution. I think the problem is that the DocC bundle is being included in the package (there's even a warning in the logs about it), that causes a resource_bundle_accessor.swift file to be injected into the compilation with an import class Foundation.Bundle, and then that conflicts with our package import Foundation.

Can you point to the branch resource-docc-fix and see if it fixes it for you? There's a chance we may want both your fix and my fix, but first I would like to confirm that resource-docc-fix does fix it.

[JanGorman]

Thanks @mbrandonw! I tested that branch on CI just now. Unfortunately it fails with same ambiguous implicit access level for import of 'Foundation'; it is imported as 'package' elsewhere error as before 😕