Improve @DependencyEntry diagnostics - #460
Open
stephencelis wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the spirit of the checks we've added elsewhere, let's better surface a few error messages that are currently buried in the macro.
Default MainActor isolation
We currently allow this to compile in modules with default MainActor isolation:
This produces a non-sendable
\.clientkey path because it's bound to the main actor, which fails only later when you try to use it:We can instead bury a default isolation check directly in the macro and surface it early:
Non-sendable dependencies
Dependencies must be sendable but currently if you try do:
The failure is buried in the macro expansion. Let's surface it instead:
Non-matching types
It's possible to invoke
@DependencyEntrywith mismatched types, especially if you forget to specifyany Clientas an existential. This produces several errors all buried in the expansion, but we can surface these as well: