Move macro runtime support into Dependencies module - #452
Open
scogeo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves runtime support used by generated
@DependencyClient/@DependencyEndpointmacro code into theDependenciesmodule. The current macro generated code introduces linkage dependencies on bothIssueReportingandDependeniesMacrosrequiring clients to import both when using a dependency that was generated with the macros.This consolidates all such macro runtime dependencies into the
MacrosSupport.swiftfile in theDependenciesmodule. This reduces the client import surface to justDependencieswhen using a macro-generated client. It must also now be imported when declaring a macro-generated dependency using@DependencyClientand related macros. In most common usage scenarios, it would normally already be imported to accessDependencyValues,TestDependencyKey, etc., but this is a potentially breaking change and should be noted if released.Summary of Changes
Dependencies._reportIssueas a small wrapper aroundIssueReporting.reportIssue.Dependencies.UnimplementedDependencyEndpointto replaceDependenciesMacros.Unimplementedin generated throwing endpoint defaults.Dependenciesinstead ofIssueReporting/DependenciesMacrosdirectly.Unimplementedtype fromDependenciesMacros.Not Addressed
DependenciesMacros.Unimplementedwas removed and not deprecated. This could potentially be an issue for users who were explicitly catching the exception type. But leaving it creates some cruft and it seems to mostly be an internal type (there was no existing test coverage for it).Validation
swift testmake test-swift