validate: run the helpers self-test - #7036
Open
vtushar06 wants to merge 1 commit into
Open
Conversation
tests/helpers.bash.t checks the assert helpers, 31 cases, and exits nonzero on failure, but nothing runs it: no Makefile target, no workflow, no reference in test_runner.sh since it was added in 2021. Hook it into validate so a break in the helpers is caught there rather than showing up as a confusing failure in a real test. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
vtushar06
force-pushed
the
validate-helpers-selftest
branch
from
August 14, 2026 13:57
8d670fc to
5d55e25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/helpers.bash.t is a working self-test for the assert helpers - 31 checks, TAP output, exits nonzero on failure - but as far as I can tell nothing runs it: no Makefile target, no workflow, no mention in test_runner.sh. Its only commit is the one that added it in 2021.
This hooks it into
make validate, which the CI validate job already runs, so a change that breaks the assert helpers gets caught before it confuses a real test run. podman recently did the same for its hack self-tests.It runs in under a second and needs no built binaries. To be clear it only covers assert(), so this is just running what already exists, not adding coverage.