Repository navigation
feat(desktop): a product sets the prefix of an app window's title - #30
Merged
Merged
Conversation
An installed app's window was titled "PocketJS: <app>" by a string in the System UI. The prefix is now `windowTitlePrefix` in pocket.about.json, the file beside the System manifest that already holds a product's About text: the System manifest's schema belongs to PocketJS and takes no other field. A file without it gives PocketJS, so this repository's desktop reads as before; an empty string titles the window with the app's title alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title of an installed app's window, in its caption and its task button, was
PocketJS: <app title>, written as a string in the System UI. A product that installs this System UI can now set the prefix.The option
windowTitlePrefixinpocket.about.json, the file beside the System manifest that holds a product's About text since #28:{ "body": ["The desktop in your room."], "link": "example.org", "windowTitlePrefix": "My Desktop" }PocketJS. This repository'spocket.about.jsondoes not set it, so its desktop readsPocketJS: Heroas before.Why this file and not
pocket.system.json: the System manifest's schema is PocketJS's (contracts/spec/pocket-system.ts) and setsadditionalProperties: false, so a new field there needs a schema change and a new pin in every product. #28 put the About text beside the manifest for the same reason.What changed
shells/desktop/src/system-ui/pocket-apps.ts:readWindowTitlePrefix,WINDOW_TITLE_PREFIX,DEFAULT_WINDOW_TITLE_PREFIXandappWindowTitle(title).shells/desktop/src/system-ui/app.tsx: the one place that titled an app's window callsappWindowTitle.shells/desktop/test/system-ui-sim.test.ts: the titles it looks for come fromappWindowTitle, so the test follows the file.shells/desktop/test/system-ui.test.ts: the default, a product's value, an empty value, values of other types, and that the About text reads the same with the field beside it.shells/desktop/README.md: the field, beside the About text.Checks
bun run checkat cd12366: exit 0 (asset check, typecheck of every shell, and the 3DS, iPod, desktop and touch tests, the desktop's simulator, wrap and text suites among them).Not verified
The simulator runs this repository's own bundle, which uses the default. A bundle built with another prefix is covered by the unit tests of the two functions, not by a simulator run. Pocket Studio will build one and holds its own test to it.
🤖 Generated with Claude Code